search

aquiladev / remix-mythx-plugin

The plugin allows executing security check via MythX in Remix IDE
http://remythx.xyz
MIT License
16 stars 14 forks source link

Submit ASTs instead of sources #3

Closed muellerberndt closed 5 years ago

muellerberndt commented 5 years ago

Description

MythX works more reliably based on ASTs and use of source code will be deprecated shortly.

Submit ASTs instead of sources in the sources dict of the request data. For an example how to construct a request with ASTs see:

https://github.com/b-mueller/sabre/blob/9ceb49218645cbcf700f4eea708a958ad306e16b/lib/client.js#L7

aquiladev commented 5 years ago

I'll take a look

yann300 commented 5 years ago

we pushed a PR https://github.com/ethereum/remix/pull/1236, in remix-alpha probably tomorrow (Tuesday)

yann300 commented 5 years ago

I think the fix should already be in remix-alpha...

aquiladev commented 5 years ago

@yann300 I checked today, still ast is not there. I checked both environments, remix and remix-alpha

yann300 commented 5 years ago

and now? (we just updated a few hours ago)

aquiladev commented 5 years ago

yes remix-alpha has ast

aquiladev commented 5 years ago

when AST is present, plugin uses it, otherwise it uses source