fix(sqlite): selectFailedBundleIds order

[karlprieb]

Changed order for selectFailedBundleIds query. Now order combine import_attempt_count and last_queued_at. Added an indexed for import_attempt_count and last_queued_at.

[coderabbitai[bot]]

Walkthrough

## Walkthrough The changes introduce an SQL migration to add and remove an index on the `bundles` table, modify a sorting order in a SQL query, and adjust a constant in the `standalone-sqlite.ts` file. These updates aim to optimize database operations by improving the performance of specific queries and adjusting reprocessing wait times. ## Changes | File Path | Change Summary | |-----------|----------------| | `migrations/2024.06.06T16.04.48.bundles.import-attempt-count-last-queued-at-indexes.sql` | Introduces a migration script to create an index on `bundles` table for `import_attempt_count` and `last_queued_at` columns. | | `migrations/down/2024.06.06T16.04.48.bundles.import-attempt-count-last-queued-at-indexes.sql` | Introduces a down migration script to drop the `import_attempt_last_queued_idx` index. | | `src/database/sql/bundles/repair.sql` | Changes sorting order in a SQL query to include `import_attempt_count` and `last_queued_at`. | | `src/database/standalone-sqlite.ts` | Changes the `BUNDLE_REPROCESS_WAIT_SECS` constant value from `60 * 60 * 4` to `60 * 1` and then to `60 * 15`. | | `test/bundles-schema.sql` | Adds a new index `import_attempt_last_queued_idx` on the `bundles` table with `import_attempt_count` and `last_queued_at` columns. |

---

Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 559c6cd362282751da48fb7cfc9a6b541034cf6f and aea388c37bb83e684f3cdab16efc5b60ace85f3d.

Files selected for processing (1)

* src/database/standalone-sqlite.ts (1 hunks)

Additional context used

Biome

src/database/standalone-sqlite.ts

[error] 2816-2816: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2820-2820: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2827-2827: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2839-2839: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2852-2852: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2868-2868: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2873-2873: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2877-2877: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2881-2881: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2889-2889: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2893-2893: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2897-2897: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2901-2901: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2905-2905: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block. --- [error] 2909-2909: Other switch clauses can erroneously access this declaration. Wrap the declaration in a block to restrict its access to the switch clause. (lint/correctness/noSwitchDeclarations) The declaration is defined in this switch clause: Unsafe fix: Wrap the declaration in a block.

Additional comments not posted (1)

src/database/standalone-sqlite.ts (1)

`75-75`: Reduced wait time for bundle reprocessing. The change from 4 hours to 15 minutes for `BUNDLE_REPROCESS_WAIT_SECS` aligns with the PR's objective to optimize the reprocessing interval. Ensure that this shorter interval does not lead to excessive database load or conflicts.

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.50%. Comparing base (db73c69) to head (559c6cd). Report is 1 commits behind head on develop.

:exclamation: Current head 559c6cd differs from pull request most recent head aea388c

Please upload reports for the commit aea388c to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #141 +/- ## ======================================== Coverage 64.50% 64.50% ======================================== Files 25 25 Lines 6469 6469 Branches 293 293 ======================================== Hits 4173 4173 Misses 2295 2295 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.