search

ar-io / ar-io-node

A scalable and modular gateway built for the permaweb atop the Arweave permanent data storage network.
https://ar.io
GNU Affero General Public License v3.0
97 stars 65 forks source link

chore(docker): update docker images for resolver and observer, add AO… #172

Closed dtfiedler closed 2 months ago

dtfiedler commented 2 months ago

… env variables.

This allows operators to provide specific AO infra to the core, observer and resolver services. It is important to note that the core and resolver services do read only, so you can modify just the AO_CU_URL and do not need to provide the others. The observer writes and signs data items, so the provided MU must accept messages from the signing wallet and process, so operators should only update the AO_MU_URL if they know that MU trusts the specific CU configured. By default, the testnet AO infra is used by all services.

coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The recent update to the `docker-compose.yaml` file introduces new environment variables (`AO_CU_URL`, `AO_MU_URL`, `AO_GATEWAY_URL`, and `AO_GRAPHQL_URL`) and updates the image tags for the `observer` and `resolver` services. These changes enhance configuration flexibility and ensure the services are using the latest images. ## Changes | File | Change Summary | |-----------------------|------------------------------------------------------------------------------------------------| | docker-compose.yaml | Introduced new environment variables (`AO_CU_URL`, `AO_MU_URL`, `AO_GATEWAY_URL`, `AO_GRAPHQL_URL`) and updated image tags for `observer` and `resolver` services. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 54ce50d8fee9d1506d986cea7305d6db4faa83eb and a752e56df7b469b6b1ca1082716869aac9693d85.
Files selected for processing (1) * docker-compose.yaml (4 hunks)
Additional comments not posted (5)
docker-compose.yaml (5)
`82-85`: **LGTM! New environment variables for `core` service.** The new environment variables `AO_CU_URL`, `AO_MU_URL`, `AO_GATEWAY_URL`, and `AO_GRAPHQL_URL` are correctly formatted and enhance configuration flexibility. --- `99-99`: **LGTM! Updated image tag for `observer` service.** The image tag for the `observer` service has been updated to `ghcr.io/ar-io/ar-io-observer:${OBSERVER_IMAGE_TAG:-917b8d5d53a901f133a49e40ae74e90e865ccbf2}`, ensuring the service uses the latest image. --- `118-121`: **LGTM! New environment variables for `observer` service.** The new environment variables `AO_CU_URL`, `AO_MU_URL`, `AO_GATEWAY_URL`, and `AO_GRAPHQL_URL` are correctly formatted and enhance configuration flexibility. --- `124-124`: **LGTM! Updated image tag for `resolver` service.** The image tag for the `resolver` service has been updated to `ghcr.io/ar-io/arns-resolver:${RESOLVER_IMAGE_TAG:-e35776ceb4324494d403b1fb900bfd06eb97a652}`, ensuring the service uses the latest image. --- `136-139`: **LGTM! New environment variables for `resolver` service.** The new environment variables `AO_CU_URL`, `AO_MU_URL`, `AO_GATEWAY_URL`, and `AO_GRAPHQL_URL` are correctly formatted and enhance configuration flexibility.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.43%. Comparing base (54ce50d) to head (a752e56).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #172 +/- ## ======================================== Coverage 67.43% 67.43% ======================================== Files 29 29 Lines 7081 7081 Branches 377 377 ======================================== Hits 4775 4775 Misses 2305 2305 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.