fix(blocks): update max fork depth from 50 to 18

Walkthrough

## Walkthrough The recent changes involve updates to constants and test cases within the `arweave` module and database-related test files. The most significant change is the modification of the `MAX_FORK_DEPTH` constant from 50 to 18. This change has cascading effects on test cases, where expected values and input parameters are adjusted accordingly to reflect the new `MAX_FORK_DEPTH` value. ## Changes | File | Summary | |----------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `src/arweave/constants.ts` | The `MAX_FORK_DEPTH` constant has been updated from 50 to 18. | | `src/database/standalone-sqlite.test.ts` | Test cases for `StandaloneSqliteDatabase` have been updated, including changes to the expected value of `stats.counts.stableBlocks` and the addition of new test data entries. | | `src/workers/block-importer.test.ts` | The input parameter for `blockImporter.importBlock()` has been modified from 51 to 19 in the test case. | ## Sequence Diagram(s) *No sequence diagrams are provided as the changes primarily involve constant updates and adjustments to test cases without significant modifications to control flow or feature implementation.*

Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 74b16a7f9d4032c9bd817526194c1f7fc8fcf481 and e470c145b787894dc453ec4b942abc18a5b0b066.

Files selected for processing (3)

* src/arweave/constants.ts (1 hunks) * src/database/standalone-sqlite.test.ts (4 hunks) * src/workers/block-importer.test.ts (1 hunks)

Additional comments not posted (4)

src/arweave/constants.ts (1)
`19-19`: **LGTM! But verify the constant usage in the codebase.** The change to `MAX_FORK_DEPTH` is correct. However, ensure that all references to `MAX_FORK_DEPTH` in the codebase are updated accordingly.

Verification successful
--- **Constant usage is verified and correct.** The constant `MAX_FORK_DEPTH` is referenced correctly across the codebase. - `src/workers/block-importer.ts` - `src/arweave/constants.ts` - `src/arweave/composite-client.ts` - `src/database/standalone-sqlite.ts`

Scripts executed
The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Verify all references to `MAX_FORK_DEPTH` in the codebase. # Test: Search for the constant usage. Expect: Only occurances of the updated value. rg --type ts -A 5 $'MAX_FORK_DEPTH' ``` Length of output: 2460

src/workers/block-importer.test.ts (1)
`196-196`: **LGTM! But verify the test case usage in the codebase.** The change to the input parameter for `blockImporter.importBlock()` is correct. However, ensure that all references to this input parameter in the test cases are updated accordingly.

src/database/standalone-sqlite.test.ts (2)
`561-566`: **LGTM! But verify the test data entries usage in the codebase.** The addition of new test data entries is correct. However, ensure that all references to these test data entries in the test cases are updated accordingly.

Verification successful
--- **Verification Successful** The new test data entries have been correctly integrated and referenced in the test cases. - References to `block_indep_hash` in the test and source files confirm the usage of the new test data entries.

Scripts executed
The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Verify all references to the new test data entries in the codebase. # Test: Search for the test data entries usage in the test files. Expect: Only occurances of the new entries. rg --type ts -A 5 $'block_indep_hash' ``` Length of output: 20918
--- `530-530`: **LGTM! But verify the expected value usage in the codebase.** The change to the expected value of `stats.counts.stableBlocks` is correct. However, ensure that all references to this expected value in the test cases are updated accordingly.

Verification successful
--- **Verification Successful: Expected Values Usage** The expected values for `stats.counts.stableBlocks` are correctly used in the respective test cases. - `assert.equal(stats.counts.stableBlocks, 181);` is used in the context of flushing blocks and transactions to stable tables. - `assert.equal(stats.counts.stableBlocks, 1);` is used in the context of copying all block fields to the stable_blocks table for a specific block height.

Scripts executed
The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Verify all references to the expected value of `stats.counts.stableBlocks` in the codebase. # Test: Search for the expected value usage in the test files. Expect: Only occurances of the updated value. rg --type ts -A 5 $'stats.counts.stableBlocks' ``` Length of output: 934 --- Script: ```shell #!/bin/bash # Description: Inspect the context around the assertions of `stats.counts.stableBlocks` to verify the correctness of the expected values. # Extract 10 lines before and after the first occurrence rg --type ts -A 10 -B 10 $'assert.equal(stats.counts.stableBlocks, 181);' # Extract 10 lines before and after the second occurrence rg --type ts -A 10 -B 10 $'assert.equal(stats.counts.stableBlocks, 1);' ``` Length of output: 147 --- Script: ```shell #!/bin/bash # Description: Use grep to extract the context around the assertions of `stats.counts.stableBlocks` to verify the correctness of the expected values. # Extract 10 lines before and after the first occurrence grep -C 10 'assert.equal(stats.counts.stableBlocks, 181);' src/database/standalone-sqlite.test.ts # Extract 10 lines before and after the second occurrence grep -C 10 'assert.equal(stats.counts.stableBlocks, 1);' src/database/standalone-sqlite.test.ts ``` Length of output: 1632

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

ar-io / ar-io-node

fix(blocks): update max fork depth from 50 to 18 #174

Codecov Report