search

ar-io / ar-io-node

A scalable and modular gateway built for the permaweb atop the Arweave permanent data storage network.
https://ar.io
GNU Affero General Public License v3.0
97 stars 65 forks source link

feat(signature-store): add redis-backed signature store #196

Closed karlprieb closed 1 month ago

karlprieb commented 1 month ago
coderabbitai[bot] commented 1 month ago
Walkthrough ## Walkthrough The changes introduce a `SignatureStore` interface and its implementation via `KvSignatureStore`, enhancing the `SignatureFetcher` class to utilize this store for efficient signature retrieval. The test suite for `SignatureFetcher` is updated to reflect this new dependency. Additionally, various modules are modified to integrate the `signatureStore` into the system, facilitating improved management and caching of signatures across the application. ## Changes | Files | Change Summary | |-----------------------------------------|-------------------------------------------------------------------------------------------------------------------------| | `src/data/signature-fetcher.test.ts` | Added `SignatureStore` dependency in tests; initialized in `beforeEach` setup and added a test case for signature retrieval. | | `src/data/signature-fetcher.ts` | Modified `SignatureFetcher` to accept `signatureStore` in the constructor; updated `getDataItemSignature` and `getTransactionSignature` methods for signature retrieval. | | `src/init/header-stores.ts` | Introduced `KvSignatureStore` import; added `makeSignatureStore` function to create a signature store instance. | | `src/routes/ar-io.ts` | Imported `signatureStore`; added logic to cache signatures based on configuration. | | `src/store/kv-signature-store.ts` | Implemented `KvSignatureStore` class with methods for managing signatures (`has`, `get`, `set`, `del`). | | `src/system.ts` | Imported `makeSignatureStore`; initialized `signatureStore` and updated `signatureFetcher` to include it in config. | | `src/types.d.ts` | Added `SignatureStore` interface defining methods for signature management. |
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between e939939f8fcb07e8892323ce31f45692f17fcff5 and aeb6518c72741adef2861a265b44890cf743dc24.
Files selected for processing (1) * src/data/signature-fetcher.test.ts (5 hunks)
Files skipped from review as they are similar to previous changes (1) * src/data/signature-fetcher.test.ts
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.60%. Comparing base (4ee04c1) to head (aeb6518). Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/data/signature-fetcher.ts 84.21% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #196 +/- ## =========================================== + Coverage 68.57% 68.60% +0.03% =========================================== Files 32 32 Lines 7735 7752 +17 Branches 435 438 +3 =========================================== + Hits 5304 5318 +14 - Misses 2430 2433 +3 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.