search

ar-tools / ar_tools

AR Marker tools for ROS
31 stars 51 forks source link

catkinize ar_tools (fixes #2) #7

Closed xqms closed 9 years ago

xqms commented 10 years ago

Here is a catkinized version of ar_tools (see #2).

ARToolKit is downloaded using the ExternalProject CMake module, analog to the download_unpack_build capability rosmake.

I added myself as maintainer in the package.xml files, since one maintainer is mandatory and I couldn't find your email. Please change that.

LucidOne commented 10 years ago

Thanks for this. I'll get this done this weekend.

xqms commented 10 years ago

Hi,

thanks for your response.

Note that @fevb has some improvements on my pull request: https://github.com/xqms/ar_tools/pull/2 I'll try to merge them in later today.

xqms commented 10 years ago

Okay, I merged in the changes from @fevb and fixed some additional CMake problems. The packages now build for me under catkin_make, catkin_make_isolated and catkin_tools. Everything seems good ;-)

If you want, I can squash the PR into fewer commits and get rid of the intermediate edits.

xqms commented 10 years ago

Could you please take a look at this? I'm starting to receive pull requests from others on top of this one, so the demand for this is quite high ;-)

dlaz commented 9 years ago

@LucidOne is this ever going to get merged? If you don't have time, it might make sense for someone else to take over maintainership (@xqms?)

xqms commented 9 years ago

@dlaz: I'm not really interested in maintaining this. I'm not even using ar_tools anymore, so probably someone else would be better suited.

dlaz commented 9 years ago

I would be willing to take over maintainership. @LucidOne, if that's ok with you, can you transfer ownership of the repo to me?

LucidOne commented 9 years ago

I also want to apologize for the delays. Co-maintainers have been added so this won't happen again.

I will also endeavor to avoid letting perfection stop progress. One day I hope that I won't have a day job that gets in the way of writing code.

Thanks for the contributions!