ar1st0crat / NWaves

.NET DSP library with a lot of audio processing functions
MIT License
453 stars 71 forks source link

Order of instruction wrong on wiki page #84

Closed TrianecT-Wouter closed 7 months ago

TrianecT-Wouter commented 11 months ago

on this page:

https://github.com/ar1st0crat/NWaves/wiki/Notes-for-non~experts-in-DSP#how-to-setup-my-filter-and-get-it-working

the example shows:

var filter = new Butterworth.HighPassFilter(order, f);

from the code (https://github.com/ar1st0crat/NWaves/blob/master/NWaves/Filters/Butterworth/HighPassFilter.cs#L26) it looks like it should be:

var filter = new Butterworth.HighPassFilter(f, order);

ar1st0crat commented 7 months ago

Good catch, thanks. Fixed. I didn't even pay attention earlier to the inconsistency between IIR and FIR design method prototypes and the order of parameters (e.g. in FirWinLp it's different). Not crucial, I guess, but annoying :(