Issue#110

[spider65]

Questa parte di codice non l'ho toccata, ma vedrò di capire cosa fare

Il gio 30 lug 2020, 13:35 Alessio Caradossi notifications@github.com ha scritto:

@alkcxy commented on this pull request.

In checker_client.py https://github.com/ara-astronomia/AutomazioneTende/pull/122#discussion_r462934260 :

                 elif k == "EO":

curtain_east = "O" elif k == "EC": curtain_east = "C" elif k == "ES": curtain_east = "S"

• code = roof + curtain_west + curtain_east
• code = roof + panel + power + light + aux + curtain_west + curtain_east

check if is better to keep it outside the for loop to have continuously update from the gpio even without touching the buttons

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ara-astronomia/AutomazioneTende/pull/122#pullrequestreview-458317508, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBMGLOR3X36QA6AWHXE7UDR6FLGZANCNFSM4O4ORZKA .

[spider65]

Idem

Il gio 30 lug 2020, 13:35 Alessio Caradossi notifications@github.com ha scritto:

@alkcxy commented on this pull request.

In checker_client.py https://github.com/ara-astronomia/AutomazioneTende/pull/122#discussion_r462934388 :

• LoggerClient.getLogger().debug("Code: %s", code)
• LoggerClient.getLogger().debug("Code: %s", code)

some as above

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ara-astronomia/AutomazioneTende/pull/122#pullrequestreview-458317650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBMGLJVIQS4VZJ7CJ4TTRLR6FLHVANCNFSM4O4ORZKA .

[spider65]

Ok, li avevo tenuti come promemoria, essendo ritornato indietro per chiudere la storia.

Il gio 30 lug 2020, 13:35 Alessio Caradossi notifications@github.com ha scritto:

@alkcxy commented on this pull request.

In checker_server.py https://github.com/ara-astronomia/AutomazioneTende/pull/122#discussion_r462934517 :

error_level: int = 0 gpioConfig = GPIOConfig() east_curtain = EastCurtain() west_curtain = WestCurtain() +#west_encoder = WestEncoder()

I think you can delete these comments

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ara-astronomia/AutomazioneTende/pull/122#pullrequestreview-458317808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBMGLL7C6UTIVHZZQOZXRDR6FLIXANCNFSM4O4ORZKA .

[spider65]

Ok

Il gio 30 lug 2020, 13:36 Alessio Caradossi notifications@github.com ha scritto:

@alkcxy commented on this pull request.

In checker_server.py https://github.com/ara-astronomia/AutomazioneTende/pull/122#discussion_r462934844 :

@@ -94,6 +133,7 @@ def convert_steps(steps):

                 roof = "O" if gpioConfig.status(GPIOPin.SWITCH_ROOF) else "C"

+

remove this line

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ara-astronomia/AutomazioneTende/pull/122#pullrequestreview-458318240, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBMGLJQ4CPTL4H43B4OOQLR6FLLLANCNFSM4O4ORZKA .

[spider65]

Avendo modificato le key per gli switch è passata anche questa modifica.

Il gio 30 lug 2020, 13:37 Alessio Caradossi notifications@github.com ha scritto:

@alkcxy commented on this pull request.

In config.ini https://github.com/ara-astronomia/AutomazioneTende/pull/122#discussion_r462935118 :

@@ -5,7 +5,7 @@

che diventa basso quando premendo l'interruttore il pin in questione vine messo a massa.

[server] -ip = 127.0.0.1 +ip = 192.168.43.78

umh, maybe it's better to keep 127.0.0.1 as default server location

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ara-astronomia/AutomazioneTende/pull/122#pullrequestreview-458318640, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHBMGLMXZF7BGD46DDXW65DR6FLOBANCNFSM4O4ORZKA .