search

ara-framework / nova-proxy

Nova Proxy is a Server-Side Include Server to compose a page with micro-frontends views
MIT License
15 stars 4 forks source link

HTTPS support #9

Open SudoCat opened 4 years ago

SudoCat commented 4 years ago

It doesn't seem to be possible to use this proxy with a HTTPS/SSL host - is that correct?

marconi1992 commented 4 years ago

That's correct. We're not supporting hosts with HTTPS/SSL mainly because Nova Proxy was planned to be used as a sidecar proxy, then we can use https in outer layers e.g a load balancer.

marconi1992 commented 4 years ago

good catch! @SudoCat, we'll elaborate more that explanation and update the Readme file accordingly.

SudoCat commented 4 years ago

Thanks for the lightning fast response! I must admit that this sort of thing is far outside my area of expertise, but we're hoping to use the ara framework to help us slowly migrate our front end away from a monolithic java ecommerce platform; I'm worried this limitation might prove to be an impassable blocker for our use case.

Would there be any plans to add SSL support to the proxy layer, or would we need to consider forking/utilising an alternative?

marconi1992 commented 4 years ago

Unfortunately, we don't have plans to add SSL support. We guess decoding the response to parse the HTML, as well as, coding it back could add performance issues. However, as I said it's only I guess. Let's keep open this issue and we'll make a proof of concept to see what we get.

zeenotheinventor commented 4 years ago

I'm interested in this as well. Would you be okay with me raising a PR to add this functionality?

marconi1992 commented 4 years ago

Sure @zeenotheinventor feel free to do it, I'll really appreciate it.