search

ara-software / AraProc

ARA data analysis framework
GNU General Public License v3.0
3 stars 1 forks source link

Surface correlation ratio and coordinates #11

Closed AlanSalcedo closed 2 weeks ago

AlanSalcedo commented 2 weeks ago

Added radius to the reco_results map. Chose to make radii dictionary part of the instantiation in standard_reco.py so I could directly access them in later function.

Wrote a function to calculate surface correlation ratio. The idea is to determine a theta range for the surface region by finding theta for the surface and for surface - z_threshold (need to determine a default for z_threshold).

Then, find max correlation and coordinates in the surface region bounded by the theta range (all phi accessible).

Finally divide by the global maximum correlation.

clark2668 commented 2 weeks ago

Just one comment, but does this need to be it's own thing like correlation.py? Seems like this could just be under standard_reco.py?

AlanSalcedo commented 2 weeks ago

Ready for the next check, @marcomuzio :)

marcomuzio commented 2 weeks ago

It's beautiful @AlanSalcedo ! Just a few small comments. Also looks like there's some conflict with the main branch.

marcomuzio commented 2 weeks ago

@AlanSalcedo thanks very much for those final changes. Good to merge!