ara-software / AraProc

ARA data analysis framework
GNU General Public License v3.0
3 stars 1 forks source link

correlation_snr, hilbert_envelope_snr, and spark_power_ratio calculations #21

Closed Mohammad-Neutrino closed 1 week ago

marcomuzio commented 2 weeks ago

@Mohammad-Neutrino thanks a lot and nice work! Overall I think this is in really good shape. You've got the right philosophy and structure for things. Just left some comments to simplify and improve in a few places.

Mohammad-Neutrino commented 2 weeks ago

Thanks a lot, @marcomuzio , I have left some responses. Let me know what you think or we can talk about this in coding session today. And then decide what to do. Thanks again!

marcomuzio commented 1 week ago

@Mohammad-Neutrino thanks this is awesome. I just requested a few tiny changes to name (sorry I'm so nitpicky lol). But this is good to go once those are changed. Great work!

Mohammad-Neutrino commented 1 week ago

closing the loop!