search

ara-software / AraRoot

ARA data access framework
2 stars 7 forks source link

Develop a4 positions pdg #65

Closed drparamita closed 5 months ago

drparamita commented 5 months ago

Hi ! thanks for checking this pull request. I made the following changes.

  1. I made changes in the makeAntInfoATRI.sql, it has the updated A4 info. A1-A3 and A5 etc info are unchanged.

  2. Similarly, I made changes in the makeCalPulserInfo.sql, so it contains new a4 info, whereas A1-A3 and A5 etc info are same in both the files.

  3. I ran the sqlite3 AntennaInfo.sqlite < makeAntenaInfoATRI.sqlto update database.

  4. then I ran sqlite3 AntennaInfo.sqlite < makeAntInfoICRR.sql
    and

  5. sqlite3 CalPulserInfo.sqlite < makeCalPulserInfo.sql ( as mentioned above,

  6. Once the changes are made, I copied the newly created sqlite to AraEvent/calib using 

    cp AntennaInfo.sqlite ../AraEvent/calib/.
cp CalPulserInfo.sqlite ../AraEvent/calib/.

    Then I added the changes, committed and pushed this branch Develop a4 positions pdg. Thank you. Paramita Dasgupta

jflaherty13 commented 5 months ago

Hey Paramita. Would you be able to open a fresh branch of AraRoot and add your changes to the A4 coordinates? This pull request is behind the main branch of AraRoot by 26 commits, so your changes have been built around a version of AraRoot from November 2022.

This pull request of AraRoot builds on its own, but I run into errors when trying to build AraSim and other scripts that depend on AraRoot. For instance, I run into conflicts with missing functions like RayTraceCorrelator::LookupArrivalTimes(), AraGeomTool::getArrayNorthingFromLatLong(), and AraGeomTool::getArrayEastingFromLatLong().

I can try to whack-a-mole these errors, but I'm worried that can cascade in a weird fork of AraRoot that will give inconsistent results.

marcomuzio commented 5 months ago

Hi @drparamita, I agree with Justin. I would open a new branch, make sure that your local AraRoot is up-to-date, commit your changes to the new branch, and then open a new pull request. Not sure if your branch being out of sync is why there are voltage calibration and pedestal files as part of this commit. Those were already committed right? We should try to keep the pull request as small as possible, so if those files need to be updated I would do so in a separate pull request.

Also, please only commit final versions of files to the main branch (i.e. not "test" files etc.). Those files tend to clutter the repo and, anyway, if we accidentally commit an error to the main branch we can always roll back to a previous commit. Thanks!