arabeyes-org / ITL

Islamic Tools and Libraries
Other
80 stars 22 forks source link

Strict C89 compliance and fixing the rounding #28

Closed mohamed closed 9 years ago

mohamed commented 9 years ago

This change includes the following:

z3bi commented 9 years ago

You should also change this line: isha = sunset + 90.0 * ONE_MINUTE;

it should be: isha = sunset + loc->calc_method.isha * ONE_MINUTE;

and instead of the if statement checking the method id, it should be checking if the type is OFFSET

z3bi commented 9 years ago

Also, my comment was actually to use NEAREST, not DOWN.

mohamed commented 9 years ago

@ameiralzoubi Both bugs above fixed. Most likely, I won't have time to work on this until next weekend in shaa Allah. If you have time, please feel free to continue. I still can check commits and give comments if you want.