search

arabidopsis / typescript-definitions

Apache License 2.0
69 stars 19 forks source link

Fix build issue where Debug not implemented on `syn::Type`. #5

Open onelson opened 4 years ago

onelson commented 4 years ago

Build fails since syn::Type only adds an impl for Debug when "extra-traits" feature is enabled. This exposes a feature on typescript-definitions-derive to control whether or not syn's feature is active, and adds a cfg_attr to the derive for Attrs.

This was mentioned incidentally in #4 but does not solve the breakage starting in nightly-2019-11-25 which seems to be related to the pest usage.

ufoscout commented 4 years ago

Any idea when this will be merged and released?

onelson commented 4 years ago

@ufoscout maintainer may not be in a rush to merge anything. There's an open PR from April which doesn't seem to have gotten any attention.

I'm not planning on publishing my fork to crates.io, but I will surely leave it up on github for as long as the problem is unaddressed (should you want to depend on it directly).

ufoscout commented 4 years ago

@onelson thanks, I am using your branch now

ytitov commented 4 years ago

would be really nice if this was merged, using @ufoscout branch. Really hoping this doesn't die. Using rust on a web api backend and having to manually write the definitions.

Fishrock123 commented 2 years ago

@arabidopsis please merge and release this

benma commented 1 year ago

Bump. Is this crate abandoned?