search

arabold / aws-to-slack

Forward AWS CloudWatch Alarms and other notifications from Amazon SNS to Slack.
MIT License
294 stars 111 forks source link

Export Lambda function ARN. #70

Closed tcourtnage closed 5 years ago

tcourtnage commented 5 years ago

Export the Lambda function ARN. Makes it easy to Fn::Import it into other templates.

homeyjd commented 5 years ago

I see you made a change to include ${Channel} in the exported name. This means a user can only create one CloudFormation stack with that parameter per AWS region.

While this may seem a reasonable restriction for your (and my) use cases, I can't endorse this approach for a base repo. This change forces users into a convention that may not work for them. Imagine a user requires alerting the same channel in multiple Slack accounts. Or perhaps a dev would clone this repo to create their own formatters or publishers.

I'm trying to keep the repo as a generic building block. In keeping with the building-block approach, any restrictions should be forked/added within the clone instead of in the base repo. Thank you for your suggestion, though!