search

arabold / serverless-sentry-lib

MIT License
32 stars 15 forks source link

Sentry Unified Node.js SDK upgrade #17

Closed aheissenberger closed 4 years ago

aheissenberger commented 5 years ago

Replace depricated Sentry Raven SDK with current Sentry Unified Node.js SDK fixes https://github.com/arabold/serverless-sentry-lib/issues/12

ahanoff commented 5 years ago

@aheissenberger ok it definitely doesn't work. I do simple revert to Raven, and it immediately sends error to sentry. If I switch to your branch and sentryConfig, events are not showing up in sentry.

Let me share my code with both: old raven and new sentry/node

ahanoff commented 5 years ago

https://github.com/ahanoff/sentry-test so here my simple aws lambda test, so your code does work with callbacks, but somehow it doesn't work with async/await. Update: you need your own dsn in serverless.yml

tobiasvoelke commented 5 years ago

Any update here? Would highly appreciate this PR. Let me know if I can support

aheissenberger commented 5 years ago

Any update here? Would highly appreciate this PR. Let me know if I can support

sorry @tobiasvoelke but I am currently blocked by other tasks and will not finish this before Ende of July

Vadorequest commented 5 years ago

Any update on this? Any help needed?

ahanoff commented 5 years ago

@Vadorequest can you test and verify if it works with async/await lambda? Maybe I'm doing something wrong, but it doesn't work for me

Vadorequest commented 5 years ago

I'm in holidays with little time available, is there a reproduction I could just fork and test to save time?

ahanoff commented 5 years ago

@aheissenberger sorry, my bad, it actually works with async/await. In my exampla I was using https://github.com/middyjs and I think I messed up with error handling there.

When this pull request can be merged?

azai91 commented 4 years ago

Any idea on when this will be merged?

polosatyi commented 4 years ago

Any updates?

arabold commented 4 years ago

Sorry for the total lack of communication from my side. I'm currently working on a major rewrite v2.0.0 based on this PR and some more changes. I'll push an update as soon as I can.

arabold commented 4 years ago

Closing this. v2.0.0 has been pushed and is being tested. A new npm update coming soon as well.