search

arabold / serverless-sentry-plugin

This plugin adds automatic forwarding of errors and exceptions to Sentry (https://sentry.io) and Serverless (https://serverless.com)
MIT License
155 stars 27 forks source link

use the enabled option #50

Closed aaronbannin closed 2 years ago

aaronbannin commented 2 years ago

Explicitly check for disabling the library.

Note: I'm not sure how to properly test these changes and am assuming the build process is automated? What else can I provide here?

aaronbannin commented 2 years ago

@arabold is there anything I can provide for this review?

arabold commented 2 years ago

Sorry for not getting back to you sooner. There's currently no enabled flag in the configuration, so this would be a new feature.

Generally, I'm open to adding an explicit flag, but this would also be needed in the SentryOptions type, we would need to add it to the serverless.yaml config and the manual. At the moment my time is somewhat limited, but I'll take a look if you don't want to update your PR yourself accordingly.

arabold commented 2 years ago

Sorry, I was completely lost and confused. Literally looked at the wrong repository 😞 I'll merge this in. Sorry for the back and forth.