search

arachnidlabs / cyflash

Bootloader tool for Cypress PSoC series microcontrollers.
BSD 2-Clause "Simplified" License
44 stars 23 forks source link

Added PSOC 4 to CANbus_Bootloader.c. Removed arbitration id filtering with hardcoded filter in protocol.py. #17

Closed remusmp closed 7 years ago

remusmp commented 7 years ago

  1. I'm developing on PSOC 4 and managed to get CANbus_Bootloader.c work for these devices (see below the line change). Before the compiler was throwing an error saying that it was implemented only for PSOC3/PSOC5.

  2. I removed the arbitration id filtering with the hardcoded filter 0x700. Maybe filtering should be implemented with python-can set_filter command, which accepts a mask as an argument (not done yet but I could look into it).

jsiverskog commented 7 years ago

Hello,

  1. The PSoC4 change looks good - happy to merge that.
  2. The arbitration change - not sure about this. I don't have a setup to test this - nor have I ever used CAN bus. Can you elaborate more on what impact it has?

If you can split up your two changes into separate pull requests they will be easier to work with/merge.

Thanks.

remusmp commented 7 years ago

I think the 0x700 is a leftover from someone who has customized the tool to their needs. See this issue: https://github.com/arachnidlabs/cyflash/issues/16

jsiverskog commented 7 years ago

Cool - thanks for the information.