Toggle load by a short button press, enter menu with a long button press when in CC mode

arachnidlabs / reload-pro

Schematics and code for the Re:load Pro

http://www.arachnidlabs.com/reload-pro/

Apache License 2.0

98 stars 32 forks source link

Toggle load by a short button press, enter menu with a long button press when in CC mode #56

Closed zardam closed 9 years ago

zardam commented 9 years ago

Possible solution for issue #30

Arachnid commented 9 years ago

Thanks for the PR! I'm a big fan of the idea in general, but there's two things that need resolving:

Use of timers (See my more detailed comment on the code)
I think a short press should invoke the menu, while a long press should enable/disable the load. This is less of a learning curve for existing users, too.

Thoughts?

zardam commented 9 years ago

I have nothing against inverting long/short press. I prefer having the function I will use the most, the most accessible, but I also agree that it hides a little bit the menu. Maybe it should be a user preference of some sort.

I will try to achieve the same behavior without the timer.

zardam commented 9 years ago

I have updated the PR :

removed the timer (manually check for the timeout of the long press in the ui task)
inverted the action of short long press

Flash used: 29968 of 32768 bytes (91,5 %). SRAM used: 3423 of 4096 bytes (83,6 %).

Diff : Flash : +272 bytes SRAM : +16 bytes

Arachnid commented 9 years ago

Sorry to be picky, but this is going to be tough to get right.

Can I suggest incorporating the changes to add 'power off' mode and to flash the backlight on various error conditions - which are straightforward and uncontroversial - into a separate CL to the one dealing with long presses?