search

arachnys / cabot

Self-hosted, easily-deployable monitoring and alerts service - like a lightweight PagerDuty
MIT License
5.6k stars 594 forks source link

Fix JenkinsCheck result status for in-progress builds #552

Closed JeanFred closed 7 years ago

JeanFred commented 7 years ago

If a build is in progress, then every JenkinsCheck was marked as failed.

Here we set the result of the JenkinsCheck to be the status of the last completed build.

Closes #551

codecov-io commented 7 years ago

Codecov Report

Merging #552 into master will increase coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   81.98%   82.09%   +0.11%     
==========================================
  Files          44       44              
  Lines        2969     2971       +2     
  Branches      178      178              
==========================================
+ Hits         2434     2439       +5     
+ Misses        474      469       -5     
- Partials       61       63       +2
Impacted Files Coverage Δ
cabot/cabotapp/jenkins.py 96.77% <100%> (+0.1%) :arrow_up:
cabot/cabotapp/models/jenkins_check_plugin.py 65.38% <100%> (-3.25%) :arrow_down:
cabot/cabotapp/models/base.py 77.21% <0%> (+0.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa33213...6f85d39. Read the comment docs.