search

arachnys / cabot

Self-hosted, easily-deployable monitoring and alerts service - like a lightweight PagerDuty
MIT License
5.59k stars 594 forks source link

Pass-through SOCIAL_AUTH_REDIRECT_IS_HTTPS from environment variables #578

Closed JeanFred closed 6 years ago

JeanFred commented 6 years ago

This is needed when running behind a reverse proxy, otherwise we get redirected to plain HTTP which does not match the expected URL in the provider.

Per the python-social-auth documentation:

On projects behind a reverse proxy that uses HTTPS, the redirect
URIs can have the wrong schema (http:// instead of https://) if
the request lacks the appropriate headers, which might cause
errors during the auth process.
To force HTTPS in the final URIs set this setting to True

https://python-social-auth-docs.readthedocs.io/en/latest/configuration/settings.html

codecov[bot] commented 6 years ago

Codecov Report

Merging #578 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   81.12%   81.13%   +<.01%     
==========================================
  Files          45       45              
  Lines        2893     2894       +1     
  Branches      173      173              
==========================================
+ Hits         2347     2348       +1     
  Misses        487      487              
  Partials       59       59
Impacted Files Coverage Δ
cabot/settings.py 68.42% <100%> (+0.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7baede7...8e2b651. Read the comment docs.