arachnys / cabot

Self-hosted, easily-deployable monitoring and alerts service - like a lightweight PagerDuty
MIT License
5.59k stars 594 forks source link

Missed custom check plugins list in many views #601

Closed decryptus closed 6 years ago

decryptus commented 6 years ago

Hi,

In the menu "New", custom check plugins weren't present in many views.

dbuxton commented 6 years ago

Sorry to be late looking at this. Are you closing because of the test failures? Looks like it's just flake8?

decryptus commented 6 years ago

Oups sorry, it is a mistake.

codecov[bot] commented 6 years ago

Codecov Report

Merging #601 into master will decrease coverage by 0.24%. The diff coverage is 71.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
- Coverage   81.05%   80.81%   -0.25%     
==========================================
  Files          46       45       -1     
  Lines        2930     2940      +10     
  Branches      177      179       +2     
==========================================
+ Hits         2375     2376       +1     
- Misses        497      505       +8     
- Partials       58       59       +1
Impacted Files Coverage Δ
cabot/templates/base.html 94.59% <0%> (-0.28%) :arrow_down:
cabot/templates/cabotapp/_statuscheck_list.html 77.09% <100%> (ø) :arrow_up:
cabot/cabotapp/views.py 70.89% <72.72%> (-0.47%) :arrow_down:
cabot/urls.py 82.5% <0%> (-0.84%) :arrow_down:
cabot/cabotapp/models/jenkins_check_plugin.py 64.91% <0%> (-0.61%) :arrow_down:
cabot/templates/404.html

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bae1719...82ca56a. Read the comment docs.

dbuxton commented 6 years ago

lgtm - @frankh can I leave with you?