arachnys / cabot

Self-hosted, easily-deployable monitoring and alerts service - like a lightweight PagerDuty
MIT License
5.59k stars 594 forks source link

Apply official Bootstrap3 styling to jQuery DataTables #613

Closed hartwork closed 6 years ago

hartwork commented 6 years ago

For your consideration

Related: https://datatables.net/examples/styling/bootstrap

codecov[bot] commented 6 years ago

Codecov Report

Merging #613 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #613      +/-   ##
========================================
+ Coverage   80.99%    81%   +0.01%     
========================================
  Files          45     45              
  Lines        2920   2922       +2     
  Branches      177    177              
========================================
+ Hits         2365   2367       +2     
  Misses        497    497              
  Partials       58     58
Impacted Files Coverage Δ
cabot/templates/base_public.html 99.21% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71b32a2...4b395b9. Read the comment docs.

hartwork commented 6 years ago

Have you had a chance to try this out, yet? What do you think about the change in looks? Personally, I don't need to have it look this very way, just unstyled (browser-specific rendering) does not seem ideal to me. Any thoughts? @dbuxton @frankh

frankh commented 6 years ago

Thanks a lot