Closed hartwork closed 6 years ago
Merging #615 into master will increase coverage by
0.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 80.98% 80.99% +0.01%
==========================================
Files 45 45
Lines 2918 2920 +2
Branches 177 177
==========================================
+ Hits 2363 2365 +2
Misses 497 497
Partials 58 58
Impacted Files | Coverage Δ | |
---|---|---|
cabot/urls.py | 83.33% <100%> (+0.83%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2c8bb9d...5bf70c9. Read the comment docs.
Any concerns or thoughts about this pull request?
@frankh @dbuxton do you have a minute?
maybe it's overkill but we should really have a test to confirm that favicon is served with status code 200. Could you add that?
Added a simple test and rebased against current master. I refrained from using reverse
as this use is a lot more clear in my eyes (and the path won't change).
Tests fixed now, please have a second look.
One of the effects is that you don't get this Django error e-mail any more:
.ico
was auto-created as following: