arachnys / cabot

Self-hosted, easily-deployable monitoring and alerts service - like a lightweight PagerDuty
MIT License
5.59k stars 594 forks source link

Serve /favicon.ico resembling current arachnys/img/icon_*x*.png files #615

Closed hartwork closed 6 years ago

hartwork commented 6 years ago

One of the effects is that you don't get this Django error e-mail any more:

[Django] ERROR: "GET /favicon.ico HTTP/1.0" 500 106

.ico was auto-created as following:

$ ( cd cabot/static/arachnys/img && convert icon_*x*.png favicon.ico && file favicon.ico )
favicon.ico: MS Windows icon resource - 2 icons, 48x48, 32 bits/pixel, 96x96, 32 bits/pixel
codecov[bot] commented 6 years ago

Codecov Report

Merging #615 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   80.98%   80.99%   +0.01%     
==========================================
  Files          45       45              
  Lines        2918     2920       +2     
  Branches      177      177              
==========================================
+ Hits         2363     2365       +2     
  Misses        497      497              
  Partials       58       58
Impacted Files Coverage Δ
cabot/urls.py 83.33% <100%> (+0.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c8bb9d...5bf70c9. Read the comment docs.

hartwork commented 6 years ago

Any concerns or thoughts about this pull request?

hartwork commented 6 years ago

@frankh @dbuxton do you have a minute?

dbuxton commented 6 years ago

maybe it's overkill but we should really have a test to confirm that favicon is served with status code 200. Could you add that?

hartwork commented 6 years ago

Added a simple test and rebased against current master. I refrained from using reverse as this use is a lot more clear in my eyes (and the path won't change).

hartwork commented 6 years ago

Tests fixed now, please have a second look.