hartwork commented 6 years ago

Hi!

This pull request is probably controversial. It is meant to start a discussion.

It may be a personal thing, a European thing, a cultural thing, you tell me. When I use software I don't like to look at company names all the time, the same way I try to keep my life as free from advertisements as possible. There are places where branding feels organic and fits in but there are two places in Cabot where I personally find the branding to invasive: they get too much attention in a way that is hard to look by. For daily operation, that matters. So this pull request reduces use of the Arachnys brand a bit.

Branding that is kept untouched includes:

Everything in README.md
The Arachnys company logo left of "Cabot" in the top nagivation bar and the effective favicon
The regex placeholder [Aa]rachnys\s+[Rr]ules

Branding that is removed:

Text by Arachnys in the top navigation bar and page title
Placeholder text https://www.arachnys.com for an HTTP check endpoint example URL

I'm happy to introduce a switch DEBRAND=False or so to development.env and friends to make this change conditional if it's more of the right direction.

What do you think?

codecov[bot] commented 6 years ago

Codecov Report

Merging #617 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files          45       45           
  Lines        2918     2918           
  Branches      177      177           
=======================================
  Hits         2363     2363           
  Misses        497      497           
  Partials       58       58

Impacted Files	Coverage Δ
cabot/cabotapp/views.py	`71.35% <ø> (ø)`	:arrow_up:
cabot/templates/base_public.html	`99.2% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36d63a5...dd1360c. Read the comment docs.

frankh commented 6 years ago

I'm ok with this, I agree the branding's unnecessary.

@dbuxton what do you think?

dbuxton commented 6 years ago

Fine by me

hartwork commented 6 years ago

Thanks!

arachnys / cabot

Reduce branding a bit? #617

Codecov Report