search

arachnys / cabot

Self-hosted, easily-deployable monitoring and alerts service - like a lightweight PagerDuty
MIT License
5.58k stars 590 forks source link

Pin flake8 dependencies to last known working versions #682

Closed JeanFred closed 3 years ago

JeanFred commented 4 years ago

The Travis-CI build has been failing for ages because of flake8: as the flake8 dependencies were not pinned, the codebase is failing when using more recent versions of flake8 (or of the underlying pycodestyle).

This pins the dependencies in the tox file to the last known working versions, as found in [1].

(This is a stop-gap measure, ideally the new violations would be fixed).

[1] https://travis-ci.org/github/arachnys/cabot/builds/424842858

JeanFred commented 4 years ago

That or #656 actually.

dbuxton commented 4 years ago

It looks like the outdated use of less is breaking build here... I don't immediately have time to fix but grateful if you do @JeanFred . Hope you are well in these troubled times!

JasonSanDiego commented 4 years ago

@dbuxton I'm interested in helping out with this project, and it seems like getting the checks to pass is a good starting point. With that said, I'm not sure where to start with this, as I don't have a lot of experience with CI. I see the errors in the log about the compressor package looking for lessc.

Can you give a pointer on where to start with this? would have expected just setting up the build environment to include lessc might help solve this, but could be way off base.

JeanFred commented 4 years ago

It looks like the outdated use of less is breaking build here... I don't immediately have time to fix but grateful if you do @JeanFred .

I had had a quick look and could not reproduce locally :-/

Closing this now that #656 is merged