search

arachnys / cabot

Self-hosted, easily-deployable monitoring and alerts service - like a lightweight PagerDuty
MIT License
5.59k stars 593 forks source link

The is_public setting for services appears to be ignored #699

Open jakubgs opened 3 years ago

jakubgs commented 3 years ago

I tried creating a service using the API but it seems to be ignoring the is_public setting.

I've also tried making it public by hand and then fetching services and I don't see it in the JSON. Is it just not supported?

I'm running cabotapp/cabot:0.11.16 Docker image.

dbuxton commented 3 years ago

Doesn't look like it - feel free to submit a PR

https://github.com/arachnys/cabot/blob/master/cabot/rest_urls.py#L50

jakubgs commented 3 years ago

So I guess the same goes for email_alert, which also appears to be ignored.

jakubgs commented 3 years ago

Based on the PRs currently open it doesn't seem like it has a high chance of getting merged.

Example: https://github.com/arachnys/cabot/pull/672

jakubgs commented 3 years ago

I have attempted to make this change in https://github.com/status-im/cabot/commit/6841f8f7 by adding is_public and email_alert but is_public works, but email_alert appears to have no effect. Not sure why that is.

jakubgs commented 3 years ago

I opened the PR: https://github.com/arachnys/cabot/pull/700

But I don't know why email_alert has no effect.