search

arachnys / cabot

Self-hosted, easily-deployable monitoring and alerts service - like a lightweight PagerDuty
MIT License
5.58k stars 590 forks source link

Migrate Cabot to Python 3.6.5 and Django 3.2.5 #710

Open Ladrusca opened 2 years ago

Ladrusca commented 2 years ago

Hi, I migrated Cabot to python 3 and it works! I also migrated the following plugins: -cabot-check-http -cabot-check-network -cabot-alert-slack -cabot-alert-email

dbuxton commented 2 years ago

I love it. Let me review

dbuxton commented 2 years ago

@Ladrusca @pablodgonzalez thanks for doing this. I'm going to carve out an hour to review this in the near future as I'd love to get merged. At the moment it's not super clear to me:

Also if you can submit pull requests for the modules you've migrated that would be great.

pablodgonzalez commented 2 years ago

Hi @dbuxton I am writing previusly to @Ladrusca do that

We have removed all plugins logic in cabot, and create an repo index with all plugins we have found in pypi/github here https://github.com/senzil/cabot-plugins

In that way cabot is thiner and more customizable to each use case.

For now we publish a pypi package named cabot3, forked all plugins and change the dependency from cabot to cabot3, no for a definitive setup but just temporal while the main cabot repo and pypi package are updated.

Right now we are working in the new Docker image and use github actions (because delete travis and docker hub has not more automated builds)

The plan is get the image working well and then add test steps in github actions. Of course, the tests about plugins does not have sense anymore. Maybe, is possible add some dummies check and alert to test the models and logic of cabot and growth the coverage?

Our idea is you can check all and to make progressive pull request to each plugin (some of course are unmaintained and I think they goes to keep in that way but the are in the index anyway)

paulkitt commented 2 years ago

Wow :)! Thanks for porting cabot to newer deps versions. Currently I have even trouble building the image. Hope the MR goes through review :)

bbarman4u commented 1 year ago

@dbuxton @Ladrusca is there any chance this PR will go through ? I am also having difficulty understanding the building and using the steps to have an updated cabot image. I was trying to follow through from the forked repo, even though the cabot image builds but the application does not start up complaining about the missing plugins, so I am not sure how the plugins are supposed to be integrated?