04/02/2014, 04:08:09
4/2/2014, 04:08:09
04/02/2014, 04:08 AM
04/02/2014, 04:08 PM
If I use luxon's date.toLocaleString(luxon.DateTime.DATETIME_SHORT) on my machine, the formats with the AM/PM are used, and that comma was breaking things.
Also fixed an error on the line _, err := p.parse() where the new err on this line was shadowing the return err, causing it and the err on further down the function to never get returned.
Added comma support and tests for this format:
04/02/2014, 04:08:09 4/2/2014, 04:08:09 04/02/2014, 04:08 AM 04/02/2014, 04:08 PM
If I use luxon's
date.toLocaleString(luxon.DateTime.DATETIME_SHORT)on my machine, the formats with the AM/PM are used, and that comma was breaking things.Also fixed an error on the line
_, err := p.parse()where the new err on this line was shadowing the return err, causing it and the err on further down the function to never get returned.