araddon / dateparse

GoLang Parse many date strings without knowing format in advance.
MIT License
2.04k stars 166 forks source link

Add test for time.Now() output #67

Closed kwk closed 6 years ago

kwk commented 6 years ago

I encountered a problem when trying to parse strings produced by time.Now().String() (e.g. "2009-11-10 23:00:00 +0000 UTC m=+0.000000001" see https://play.golang.org/p/L6NpVXAtSur).

I'd be surprised if the PR passes tests.

codecov-io commented 6 years ago

Codecov Report

Merging #67 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #67   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines         730    730           
=====================================
  Hits          730    730

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 42dbd9f...18a53e2. Read the comment docs.

kwk commented 6 years ago

My bad. I discovered a problem in my code :/

araddon commented 6 years ago

no worries, thanks for pr and the validation though!