arades79 / hyperdome

the safest place to reach out
Other
27 stars 1 forks source link

Remove shutdown timer #101

Closed arades79 closed 4 years ago

arades79 commented 4 years ago

Summary

While creating unit tests it was observed that the ShutdownTimer class in the common module was duplicating the native functionality of threading.Timer, and may introduce unecessary bugs.

Initially, the plan was to replace the ShutdownTimer implementation with the native timer. However after completing the change, it became unclear if the functionality provided by the shutdown timer is a useful feature for the hyperdome server where it was used. Thus the functionality was removed.

If in the future this functionality is required again, a new PR will be created to implement the functionality.

This PR closes #95

Checklist