While creating unit tests it was observed that the ShutdownTimer class in the common module was duplicating the native functionality of threading.Timer, and may introduce unecessary bugs.
Initially, the plan was to replace the ShutdownTimer implementation with the native timer. However after completing the change, it became unclear if the functionality provided by the shutdown timer is a useful feature for the hyperdome server where it was used. Thus the functionality was removed.
If in the future this functionality is required again, a new PR will be created to implement the functionality.
This PR closes #95
Checklist
[x] If code changes were made then they have been tested.
[x] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[x] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)
Summary
While creating unit tests it was observed that the ShutdownTimer class in the common module was duplicating the native functionality of threading.Timer, and may introduce unecessary bugs.
Initially, the plan was to replace the ShutdownTimer implementation with the native timer. However after completing the change, it became unclear if the functionality provided by the shutdown timer is a useful feature for the hyperdome server where it was used. Thus the functionality was removed.
If in the future this functionality is required again, a new PR will be created to implement the functionality.
This PR closes #95
Checklist