Should the UI classes contain as much logic as they do?

arades79 / hyperdome

the safest place to reach out

Other

27 stars 1 forks source link

Should the UI classes contain as much logic as they do? #35

Open stevenpitts opened 5 years ago

stevenpitts commented 5 years ago

Currently, a lot of the logic is being performed in the UI classes, like HyperdomeClient. The issues with this:

Tests will be more difficult to run
UI changes could break logic
Feels like poor programming

I think we should keep the logic in HyperdomeClient, but move the UI aspects to a new class. Do you agree?

stevenpitts commented 5 years ago

Hmm, I may be overthinking this; looking at it again, there's not too much logic in there. Edit: I'm not. But the issue is more with separation of class UIs and logic; for example; the Server object is located in the "add_server_dialog" file.

arades79 commented 4 years ago

I would like to at some point re-do the UI using QML or some other more self contained Qt code, exposing the interface in such a way that a sort of MVC paradigm can be used to organize the code. The models can then be moved up to the common code base between server and client.