search

arades79 / hyperdome

the safest place to reach out
Other
27 stars 1 forks source link

Fix hyperdome_connection test for API changes introduced in 0.1 #57

Open arades79 opened 4 years ago

arades79 commented 4 years ago

The hyperdome connection integration test needs to be updated to reflect API changes made. The existing integration test uses hard-coded API calls external to those used in the client to avoid the pyqt dependency. In 0.1 release most API calls are moved to package level functions which can be used in the integration test to verify both server and client are working as expected.

Note that this integration test is not a replacement for good unit tests, but serves as a good sanity baseline for changes.

arades79 commented 4 years ago

I'm changing the goal of this issue to instead be to write an integration test for the pytest suite already pulled in for 0.3.

The code in hyperdome_connection was very tightly coupled to the existing codebase, and didn't actually do any testing on the client.

By leveraging pytest-pyqt, and because of the non-qt-dependent client code due to ship in 0.3 it will be more robust to write a new test that performs all the actions hyperdome_connection did in a more repeatable and regression testable manner.

I'm also pushing this back again since this increases the scope too much to fit in the deadline set for 0.3