search

aradzie / keybr.com

The smartest way to learn touch typing and improve your typing speed.
https://www.keybr.com/
GNU Affero General Public License v3.0
1.76k stars 155 forks source link

Add Thai language support #276

Open longman694 opened 3 weeks ago

longman694 commented 3 weeks ago

Hi there,

I would like to contribute by adding Thai language support to this project.

I used this PR as a guide, and I have forked the project and added a dictionary and layouts here.

However, the Thai language and layouts are not showing up in the keyboard option. I must be missing something. Could you please guide me on how to fix this?

longman694 commented 3 weeks ago

Ok, I just forgot to build it >.<

longman694 commented 3 weeks ago

Testing so far - it's working great! The only two problems I found are:

  1. The "All keys:" row is overflowing.
  2. A base character and upper/lower characters (vowels and accents entered by different keys) are not updated separately. Both colors change after the center character input.

image

aradzie commented 3 weeks ago

That's interesting! Please give me a day or two to educate myself about the Thai language, and review your changes.

longman694 commented 3 weeks ago

Thanks, @aradzie!

I've also completed the Thai translation on POEditor.

aradzie commented 3 weeks ago

Thanks, @aradzie!

I've also completed the Thai translation on POEditor.

You are awesome! I have updated the website with the Thai translation -- https://www.keybr.com/th/index

aradzie commented 3 weeks ago

From what I understand, there are a couple of challenges in adding the Thai language:

  1. Absolutely enormous alphabet, where only consonants are taking 44 separate characters.
  2. The usage of combining characters, like ◌ั ◌ิ ◌ุ and so on.

I made a local copy of your changes on my workstation and played with it for a bit. I believe it can be a starting point before the Thai language is completely supported in keybr, and more changes will be required to fix the remaining issues.

So please go ahead and make a PR!

longman694 commented 3 weeks ago

@martijn, I've made some updates to the translation on POEditor. Please apply the update when you have the time. Thank you!