search

araffin / rl-baselines-zoo

A collection of 100+ pre-trained RL agents using Stable Baselines, training and hyperparameter optimization included.
https://stable-baselines.readthedocs.io/
MIT License
1.13k stars 208 forks source link

Tensorboard log directory creation fails on windows with train.py #11

Closed iandanforth closed 5 years ago

iandanforth commented 5 years ago

On Windows if you pass the --tensorboard-log argument to train.py it will fail to create the proper directory structure.

Traceback (most recent call last): File "train.py", line 189, in main() File "train.py", line 169, in main model.learn(n_timesteps) File "c:\users\ian\clones\stable-baselines\stable_baselines\ppo2\ppo2.py", line 255, in learn with SetVerbosity(self.verbose), TensorboardWriter(self.graph, self.tensorboard_log, tb_log_name) as writer: File "c:\users\ian\clones\stable-baselines\stable_baselines\common\base_class.py", line 558, in enter self.writer = tf.summary.FileWriter(save_path, graph=self.graph) File "C:\Users\Ian\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\summary\writer\writer.py", line 352, in init filename_suffix) File "C:\Users\Ian\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\summary\writer\event_file_writer.py", line 67, in init gfile.MakeDirs(self._logdir) File "C:\Users\Ian\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\lib\io\file_io.py", line 374, in recursive_create_dir pywrap_tensorflow.RecursivelyCreateDir(compat.as_bytes(dirname), status) File "C:\Users\Ian\AppData\Local\Programs\Python\Python36\lib\site-packages\tensorflow\python\framework\errors_impl.py", line 516, in exit c_api.TF_GetCode(self.status.status)) tensorflow.python.framework.errors_impl.NotFoundError: Failed to create a directory: tblogs/MuscledAnt-v0\PPO2_1; No such file or directory

Cause

This is due to https://github.com/araffin/rl-baselines-zoo/blob/master/train.py#L51 which should instead use os.path.join()