Closed laurelkeys closed 4 years ago
Hello, Could be please fill the issue template completely?
Done.
Ok, you are not using the script from the zoo, that explains why you have errors... This is definitely not recommended.
Anyway, I understand the concern, I would appreciate if you submit a PR that set hyperparams={}
if None
is passed.
Describe the bug The current default value form
hyperparams
raises an AttributeError inutils.create_test_env
.Code example
Traceback:
System Info Running on Colab, with version 2.9.0a0 of Stable Baselines, and using the code after cloning the repository as:
(where each line is a code cell).
Additional context In the
create_test_env
function,hyperparams=None
by default: https://github.com/araffin/rl-baselines-zoo/blob/da52f568282de8e3b0a7435eb64c752d00568ca3/utils/utils.py#L136-L138However, this raises an AttributeError ('NoneType' object has no attribute 'keys') when trying to call
hyperparams.keys()
: https://github.com/araffin/rl-baselines-zoo/blob/da52f568282de8e3b0a7435eb64c752d00568ca3/utils/utils.py#L163Shouldn't
hyperparams={}
by default? Or keep itNone
, but add a check for it in the line above?