Add the universal support for the Prodigy xy files

arafune / arpes

Fork of PyARPES the open source ARPES analysis framework, which seems not to be maintained.

Other

4 stars 2 forks source link

Add the universal support for the Prodigy xy files #2

Closed mkopciuszynski closed 9 months ago

mkopciuszynski commented 9 months ago

Hi,

I propose to add the support for prodigy xy files in a separate plugin. This plugin was written based on the code (if you don't mind) of the prodify_itx plugin for easier maintenance.

The IF_UMCS plugin was also changed to use load_xy routine.

Reagards, Marek

arafune commented 9 months ago

Consider the following points for improvement from the viewpoint of robustness:

The key of attrs should be the snake_case format. and "/" should be avoided
- I consider utilizing TypedDict / Pydantic in future.
Use np.deg2rad for converting deg to rad.
Ensure there are no errors in Ruff (>=0.1.14) and Mypy. (>=1.8.0)

arafune commented 9 months ago

IF_UMCS.py:17:7: N801 Class name IF_UMCS should use CapWords convention

You can ignore this ruff error.