search

aragon / aragon-cli

CLI for creating and publishing Aragon apps
GNU General Public License v3.0
91 stars 79 forks source link

truffle.js vs truffle-config.js #110

Closed Quazia closed 6 years ago

Quazia commented 6 years ago

On Windows machines, it's often necessary to rename the truffle config file truffle-config.js so as to avoid confusion with truffle (the tool). There are other solutions but when going with the name change route the following is output:

[20:07:36] Start a local Ethereum network [started]
[20:07:36] Start a local Ethereum network [failed]
[20:07:36] → Cannot read property 'connection' of undefined
 × Cannot read property 'connection' of undefined

I believe it is the following line that becomes problematic: https://github.com/aragon/aragon-cli/blob/a43747cc1e70ddc371640e9f9ab349b3725149d0/src/helpers/truffle-config.js#L6

suggested solution would be something along the lines of creating an additional else-if statement to handle truffle-config.js.

If another solution is used (such as removing the .JS extension from PATHEXT environment variable) aragon run can successfully start the network so this isn't a critical issue.

izqui commented 6 years ago

105 adds support for ‘truffle-config.js’ files :)

Quazia commented 6 years ago

Silly me I should have known from that amazing PR description 👍

izqui commented 6 years ago

LOL sorry @Quazia. Closed by #105