aragon / aragon-cli

CLI for creating and publishing Aragon apps
GNU General Public License v3.0
91 stars 79 forks source link

Updated source code to remove the deprecated go-ipfs version #1868

Closed JeremyConnor closed 3 years ago

JeremyConnor commented 3 years ago

🦅 Pull Request Description

This pull request is a solution to the bug stated in the issue 1833. npm run pretest doesn't work as it gives deprecated go-ipfs error.

Rational

As of now, the source code in master branch is hard-coded to use 0.4.22 version of go-ipfs which is already giving the deprecation error. My updated code doesn't look for version specific go-ipfs. It downloads the LTS version of go-ipfs and thus even if any of the version gets deprecated, it won't affect aragon-cli as it will then work on the latest version.

🚨 Test instructions

The testing is pretty straight-forward, clone the branch locally, run the commands yarn install, yarn run build, yarn run pretest. yarn run pretest should successfully install the go-ipfs which can then be used to run yarn test.

✔️ PR Todo

welcome[bot] commented 3 years ago

Thanks for opening this pull request! Someone will review it soon 🔍

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! Aragon is proud of you 🦅 Eagle gif