search

aragon / aragon-cli

CLI for creating and publishing Aragon apps
GNU General Public License v3.0
91 stars 79 forks source link

Solidity parser fails on fallback function #283

Open sbc64 opened 5 years ago

sbc64 commented 5 years ago

The solidity parser fails when there is fallback function BUT it only happens when there is no space.

Works: function () payable {}

Does not work: function() payable {}

$ aragon run
  ✔ Building frontend
  ✔ Prepare files for publishing
  ✖ Generate application artifact
    → Cannot read property 'split' of undefined
    Publish althea.aragonpm.eth
    Fetch published repo
  Create DAO

The culprit is this line: https://github.com/aragon/aragon-cli/blob/master/src/helpers/solidity-extractor.js#L18

It isn't urgent for this to get solved, but I'd rather see this documented until the regex gets updated to handle this. :smiley:

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅