search

aragon / aragon.js

(Aragon 1) A monorepo of JavaScript libraries for interacting with Aragon
https://aragon.org
GNU Affero General Public License v3.0
82 stars 58 forks source link

Wrapper: support ACL intents for api.external handles #424

Closed sembrestels closed 4 years ago

sembrestels commented 4 years ago

Fixes #417.

Changes

Support ACL transaction path discovery when performing actions in the ACL obtained from api.external() such as:

const aclHandler = api.external(aclAddr, aclAbi)
aclHandler.revokePermission(entity, app, role).toPromise()

If you are modifying the external API of one of the modules, please remember to also change the documentation

It doesn't change the API

welcome[bot] commented 4 years ago

Thanks for opening this pull request! Someone will review it soon 🔍

sembrestels commented 4 years ago

Code moved to getExternalTransactionPath() and test added.

welcome[bot] commented 4 years ago

Congrats on merging your first pull request! Aragon is proud of you 🦅 Eagle gif

sohkai commented 4 years ago

@sembrestels Sorry this took a bit to land into the client; we were busy with a few other efforts surrounding the Court.

This is now available as part of 0.8.8, which you can grab and run now, or otherwise wait to use it from a new version of the CLI (v7.1.1) that will be published in the next day or so.

sembrestels commented 4 years ago

Thanks @sohkai. I've just tested it and everything works as expected!