DAO-212: fix private network type issue with polygon mumbai

aragon / aragon.js

(Aragon 1) A monorepo of JavaScript libraries for interacting with Aragon

https://aragon.org

GNU Affero General Public License v3.0

82 stars 58 forks source link

DAO-212: fix private network type issue with polygon mumbai #483

Closed yuetloo closed 3 years ago

yuetloo commented 3 years ago

@novaknole This change pulls in use-wallet's KNOWN_CHAINS to map mumbai's network type, noticed a lot of ethersproject dependencies pulled in as a result... please review if it's ok.

welcome[bot] commented 3 years ago

Thanks for opening this pull request! Someone will review it soon 🔍

linear[bot] commented 3 years ago

DAO-212 My DAOs

As a user I want to be able to add a DAO to my list of favorite DAOs (including the ones I create), so I have quick access to them

yuetloo commented 3 years ago

Hmm... the size of wrapper almost doubled after pulling use-wallet causing the CI main to fail.. the other CI may be related to using branch instead of npm package... will test it out later..

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! Aragon is proud of you 🦅 Eagle gif