aragon / aragon.js

(Aragon 1) A monorepo of JavaScript libraries for interacting with Aragon
https://aragon.org
GNU Affero General Public License v3.0
82 stars 58 forks source link

update: added support for block size limit on getPastEvents #489

Closed victaphu closed 2 years ago

victaphu commented 2 years ago

Harmony One limits the number of blocks returned by getPastEvents to only 1024. Beyond that and the API throws an exception.

Changes

If you are modifying the external API of one of the modules, please remember to also change the documentation

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

nivida commented 2 years ago

LGTM and thanks a lot for doing those changes:))

victaphu commented 2 years ago

Hi @nivida,

In case you missed it, you need to accept the CLA (see above) so this branch can merge and release

Thanks Victa

welcome[bot] commented 2 years ago

Congrats on merging your first pull request! Aragon is proud of you 🦅 Eagle gif