aragon / buidler-aragon

(Aragon 1) Buidler plugin for Aragon App development
24 stars 21 forks source link

Consider using BuidlerPluginError instead of plain errors #191

Open fvictorio opened 4 years ago

fvictorio commented 4 years ago

This isn't exactly a bug, but there wasn't a better option in the templates :sweat_smile:

buidler-aragon throws plain errors, like this one: https://github.com/aragon/buidler-aragon/blob/e238f3240c1aba3d351d372179bccf54cd345321/src/tasks/publish/parseAndValidateBumpOrVersion.ts#L46

It's better to throw BuidlerPluginErrors from Buidler plugins, since that lets buidler give better feedback to the user. Relevant section in the docs: https://buidler.dev/advanced/building-plugins.html#throwing-errors-from-your-plugins

welcome[bot] commented 4 years ago

Thanks for opening your first issue in aragonCLI! Someone will circle back soon ⚡