sohkai
commented
5 years ago Related: https://github.com/aragonone/product/issues/51
Incoming transfers from the vault should not be a problem to visualize.
The budgeting problem can be mitigated slightly if we're able to provide some documentation for the Vault and Agent's transfer roles to be primarily given to an attached Finance app, and that direct transfers should happen through the Finance app. With the "safe" execution improvements to the Agent app, typical use should consist of non-financial interactions with other contracts so that financial ones happen with the Finance app.
However, this does start to make a organization-level constraints module sound more and more compelling.
luisivan
marsrobertson
lkngtn
Is your feature request related to a problem? Please describe. If you want to use a vault/agent instance to hold funds, and the finance app to view the current state of assets in a vault, there can be discrepancy between the amount of funds in the vault and the transaction log in the finance app. This can happen with the agent app if you make token transfers directly with the
dao actcommand. Or when multiple applications (such as TPS projects or allocations) are connected to the same vault as the finance app.Describe the solution you'd like The transaction log displayed in finance should show all incoming and outgoing transfers for watched tokens in its log, even if they were not triggered via the finance app directly.
Describe alternatives you've considered If all transactions were routed through the finance app (including transfer requests associated with other apps like projects or allocations) then finances transaction log (and also its budgeting capability) would work correctly. However, this seems problematic unless we created a tight coupling between the vault/agent/finance app functionality.
Additional context This same issue also breaks the finance's hidden budget functionality, as the budget only applies to transactions which are sourced from the finance app, and not from other sources.