aragon / client

(Aragon 1) Create and manage decentralized organizations on Ethereum.
https://client.aragon.org
GNU Affero General Public License v3.0
829 stars 273 forks source link

Not having the required permissions to execute a pending enactment #803

Closed abramsymons closed 5 years ago

abramsymons commented 5 years ago

Describe the bug We have a strange problem in BlankDAO after upgrading our DAO to latest version. It seems none of us are able to execute a pending enactment. The error message is:

Action impossible The action failed to execute. You may not have the required permissions.

You can see votings list here: https://mainnet.aragon.org/#/blankdao.aragonid.eth/0x10f1020fcb0ef990b3c555890b53db5fd87e7a85 Problem is with the last pending vote with this as reference message: "Finance: Create a new payment of 918.55 DAI to ... executing 1 times at intervals of 0 seconds, for 'Mahdi Heydari | Last 15 days tasks https://bit.ly/2X3Lzxl"

Mainnet or testnet? Mainnet

Organization https://mainnet.aragon.org/#/blankdao.aragonid.eth

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://mainnet.aragon.org/#/blankdao.aragonid.eth/0x10f1020fcb0ef990b3c555890b53db5fd87e7a85'
  2. Open the last pending vote with this as reference message: "Finance: Create a new payment of 918.55 DAI to ... executing 1 times at intervals of 0 seconds, for 'Mahdi Heydari | Last 15 days tasks https://bit.ly/2X3Lzxl"
  3. Execute the vote
  4. See error: "The action failed to execute. You may not have the required permissions."

Expected behavior I expect that pending enactments should be allowed to be executed by anyone.

Screenshots I attached 2 screenshots from the vote I'm trying to execute and the error message I'm seeing screenshot-mainnet aragon org-2019 05 27-11-45-10 screenshot-mainnet aragon org-2019 05 27-11-43-54

Desktop (please complete the following information): I tested on different computers with different os, browsers and metamask version. Followings are for my laptop:

Smartphone (please complete the following information):

Additional context I faced this problem after upgrading the DAO, but I don't know that it's related to the upgrade

izqui commented 5 years ago

If the vote was created before upgrading the Finance app in the DAO, the issue is related to the upgrade. The new version of Finance changed the entry-point function for creating new payments, removing the old one, which is why the execution of the vote would fail.

Votes to perform Finance transfers that were created before the upgrade need to be re-created.

abramsymons commented 5 years ago

Thanks for the feedback. I will re-create the vote.