Support labels for transaction hashes

aragon / client

(Aragon 1) Create and manage decentralized organizations on Ethereum.

https://client.aragon.org

GNU Affero General Public License v3.0

830 stars 273 forks source link

Support labels for transaction hashes #903

Open sohkai opened 5 years ago

sohkai commented 5 years ago

On a per-app basis, we could attach string labels to transaction hashes. This would alleviate the need for a reference field to be propagated via Ethereum state or events, and could be synced across the org once https://github.com/aragon/aragon/issues/902 is available.

These need to be done on a per-app basis (or perhaps with even more granularity via log indexes), because a single transaction (with one hash) can do many things (especially if done through via an transaction bundler like CallsScript).

luisivan commented 5 years ago

@sohkai what do you mean by attaching string labels to transaction hashes? Does that mean that the app can also pass along a string to the client, that gets attached after transaction signature?

sohkai commented 5 years ago

What do you mean by attaching string labels to transaction hashes?

Similar to a custom label for an address, a user could annotate a transaction hash with a label.

A few options for accessing this:

Adding a input field to the signer panel, asking the user to annotate their action (if necessary)
Clicking on a transaction in the activity panel to bring up this annotation mode
Apps implementing this action in a context menu / etc. similar to adding custom labels

Apps could then resolve these transaction hashes, similar to addresses.