Closed jonlac closed 6 years ago
Thanks for the report, paging in @harshjv
I'll add my feedback to this issue as well. Here are a few things I noticed on this page.
In this section:
It took me a second to realize that USD did make sense to use here since its a unit of value most people are familiar with. It would be helpful to show the math and the total amount of ETH required underneath in the UI. eg:
100 * 0.003 ETH = 0.3 ETH (100 USD)
I actually didn't send the right amount of ETH to the contract the first time and the error message wasn't super helpful - it took me a second to figure out what was going wrong. I don't know exactly how this would work but linking to an invoice page would be pretty cool for this.
Another thing on this page that would be helpful is a tooltip explaining the exact consequences of the close date.
@jonlac Hey, can you confirm that you didn't change anything in "Round Closes" in the first issue? Also, regardless of "Round Closes", did you see the MetaMask popup to confirm/sign transactions/data? Because I can't reproduce this issue.
No, I didn't. It got stuck before I could change it. And if I clicked out it recovered but repeating the typing/enter got it stuck again. And I didn't remember to see either the MetaMask popping up, but I just did it again to check it out and it did pop up (without giving it a date nor a name), and look what happened once confirmed (thrice) and approved after the voting. I also tried typing in the 'Amount' in a new payment and it also got stuck. [I'm using the desktop version in Windows 10]. Let me know if I can try something to clarify the issue. :)
@jonlac Thanks a lot mate for the info. I'll try to reproduce this issue with given details on a Windows PC. I'll ping you if I need something. :)
1st: When you try to set the 'Share Price' and instead of using the arrows you type it in and then press 'Enter', it sends Aragon to sleep.
2nd: The 'Share Price' number format leads to figures overlaying.
3rd: (Suggestion) It would be good to ban past dates in 'Round closes' interval to avoid leading to an instant closing.
And that's it. Best regards,
@lacasito