F/split transaction actions - Githubissues

aragon / osx

Aragon OSx Protocol

GNU Affero General Public License v3.0

85 stars 43 forks source link

F/split transaction actions #562

Closed jordaniza closed 7 months ago

jordaniza commented 7 months ago

Description

This PR merges as follows:

flowchart LR
    fsplit_transaction_actions("f/split-transaction-actions") --> fsplit_subgraph("f/split-subgraph") --> fsplit("f/split") --> develop
    other_prs("{other prs}") --> fsplit_subgraph

We are staging these PRs to make reviewing and readability easier but all achieve the same goal: deprecating plugins in OSx core.

Summary of PRs:

[ ] Remove Proposals from Executions, Transfer entities and add deterministic IDs ${\color{Red}<-- This PR}$
[ ] Remove Plugin data from the Subgraph
[ ] Rename TransactionActions back to Actions
[ ] Move ID generation to OSx Commons if needed

This PR

*This PR will fail tests as ERCXXX proposals have not been updated, this is deliberate to make the PR readable *

Removes the concept of 'proposals' from the handle execution workflow
Rename 'Proposal' to 'TransactionActions' which is a junction table for DAO <-> Actions grouping said actions in execution batches
TransactionAction is a temp entity that replaces Action. It will be renamed back to action when it no longer causes a namespace collision with the plugins
Adds deterministic IDs to TransactionActions and TransactionAction
Fixes tests and adds some small comments

Task ID: OS-1199

Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have selected the correct base branch.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.
[ ] I ran all tests with success and extended them if necessary.
[x] I have updated the CHANGELOG.md file in the root folder.
[ ] I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
[ ] I have updated the UPDATE_CHECKLIST file in the root folder.
[ ] I have updated the Subgraph and added a QA URL to the description of this PR.