aragon / osx

Aragon OSx Protocol
GNU Affero General Public License v3.0
84 stars 43 forks source link

f: removed start and end date from tx actions and made entities immut… #569

Closed jordaniza closed 5 months ago

jordaniza commented 5 months ago

Description

This PR merges as follows:

flowchart LR
    fsplit_immutable_transactions("f/immutable-transactions")  --> fsplit_transaction_actions("f/split-transaction-actions") --> fsplit_subgraph("f/split-subgraph") --> fsplit("f/split") --> develop
    other_prs("{other prs}") --> fsplit_subgraph

We are staging these PRs to make reviewing and readability easier but all achieve the same goal: deprecating plugins in OSx core.

Summary of PRs:

This PR

IDAO.execute will now create TransactionActions and Arrays of TransactionAction, these will be uniquely created inside each transaction, so there is never a need to update them.

This PR marks the entities as immutable then removes branching to fetch the entity from the DB if it exists already.

Task ID: OS-1210

Type of change

Checklist: